Skip to content

check for new phx.new version #6012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 17, 2025
Merged

check for new phx.new version #6012

merged 7 commits into from
Feb 17, 2025

Conversation

SteffenDE
Copy link
Contributor

@SteffenDE SteffenDE commented Dec 11, 2024 •
edited
Loading

Adds a warning message at the end of the phx.new output if a newer version of the installer is available:

image

@SteffenDE SteffenDE force-pushed the sd-phx-new-version-check branch from fff7a5e to b4c0066 Compare December 11, 2024 16:06
@SteffenDE
Copy link
Contributor Author

Should we do something about the warnings on Erlang < 25?

.[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
.[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
..[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.
[hex_http_httpc] using default ssl options which are insecure.
Configure your adapter with: {hex_http_httpc, #{http_options => [{ssl, SslOpts}]}}
or upgrade Erlang/OTP to OTP-25 or later.

@SteffenDE SteffenDE marked this pull request as ready for review December 11, 2024 17:27
@SteffenDE SteffenDE requested a review from josevalim January 26, 2025 12:28
@SteffenDE SteffenDE force-pushed the sd-phx-new-version-check branch from f110ff0 to cc1223b Compare January 26, 2025 12:35
josevalim
josevalim reviewed Jan 26, 2025
View reviewed changes
installer/mix.exs Outdated
@@ -61,6 +61,7 @@ defmodule Phx.New.MixProject do

def deps do
[
{:hex_core, "~> 0.11.0"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archives cannot include dependencies afaik :(

We will need to request against Hex API.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworked to use https://hex.pm/api/packages/phoenix instead. But as we need to parse JSON without a dependency, the whole check is gated behind an Elixir version check now.

@josevalim
Copy link
Member

@SteffenDE should we check before we do anything, to make sure they are generating an app in the latest version?

@SteffenDE SteffenDE force-pushed the sd-phx-new-version-check branch from cc1223b to f828747 Compare February 17, 2025 14:44
@SteffenDE
Copy link
Contributor Author

@SteffenDE should we check before we do anything, to make sure they are generating an app in the latest version?

I don't know who said it, maybe Chris, but initial feedback was that it should not block the task from proceeding.

josevalim
josevalim reviewed Feb 17, 2025
View reviewed changes
@SteffenDE SteffenDE merged commit cd8a73a into main Feb 17, 2025
10 checks passed
@SteffenDE SteffenDE deleted the sd-phx-new-version-check branch February 17, 2025 21:40
@frankdugan3 frankdugan3 mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteffenDE @josevalim